Skip to content

Conversation

@abillingsley
Copy link
Collaborator

Proposed Change

Types of changes

What types of changes does your code introduce to SignalR-ObjC? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Alex Billingsley and others added 8 commits March 18, 2016 14:38
The method to create a connection from a URL string is named [SRConnection connectionWithURLString:] - fixing the example code to use it.
Base verbose log method had a typo in its name which meant it failed to compile ":5: Implicit declaration of function 'SRLogVerboase' is invalid in C99" when one of the verbose methods was used.
Fixing typo that broke verbose logging
Replacing connectionWithURL: with connectionWithURLString:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants